-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[tutorials] Get rid of experimental category #18153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RCanvas
is still experimental.
Also RFitPanel
is remains in Experimental
namespace.
Therefore related tutorials can remain in the experimental
section
Actually, the experimental category was created during the ROOT hackathon last November, see #17097. During the RRetreat, we agreed on getting rid of this category. Tutorials showcasing experimental features should be placed in the relevant category, but they should be labelled with a warning message. |
But fitpanel.cxx can be kept? |
Test Results 17 files 17 suites 3d 21h 43m 59s ⏱️ Results for commit 4f0a24b. ♻️ This comment has been updated with latest results. |
@mdessole Can you recover fitpanel.cxx and rebase PR? |
1cc63ea
to
f807e11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While RHist class will be removed,
one of course should remove related code in RFitPanel and and RBrowser
42ab320
to
b093990
Compare
277232d
to
a62096c
Compare
a62096c
to
fdd0a9c
Compare
fdd0a9c
to
4f0a24b
Compare
Debian125 failure not related to code changes, merging. |
This Pull request: