Skip to content

[tutorials] Get rid of experimental category #18153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2025

Conversation

mdessole
Copy link
Contributor

This Pull request:

  • moves RCanvas tutorials to visualisation
  • deletes RHist tutorials
  • moves RBrowser and RFileDialog tutorials to visualization/webgui and removes warnings (not in experimental namespace anymore)
  • moves RFitPanel tutorial to visualization/webgui

@mdessole mdessole requested a review from martamaja10 March 26, 2025 14:41
@mdessole mdessole self-assigned this Mar 26, 2025
Copy link
Member

@linev linev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RCanvas is still experimental.
Also RFitPanel is remains in Experimental namespace.

Therefore related tutorials can remain in the experimental section

@mdessole
Copy link
Contributor Author

mdessole commented Mar 26, 2025

RCanvas is still experimental. Also RFitPanel is remains in Experimental namespace.

Therefore related tutorials can remain in the experimental section

Actually, the experimental category was created during the ROOT hackathon last November, see #17097. During the RRetreat, we agreed on getting rid of this category. Tutorials showcasing experimental features should be placed in the relevant category, but they should be labelled with a warning message.

@mdessole mdessole requested a review from linev March 26, 2025 15:22
@linev
Copy link
Member

linev commented Mar 26, 2025

But fitpanel.cxx can be kept?
It shows usage of RFitPanel with RHist classes.

Copy link

github-actions bot commented Mar 26, 2025

Test Results

    17 files      17 suites   3d 21h 43m 59s ⏱️
 2 730 tests  2 730 ✅ 0 💤 0 ❌
45 035 runs  45 035 ✅ 0 💤 0 ❌

Results for commit 4f0a24b.

♻️ This comment has been updated with latest results.

@linev
Copy link
Member

linev commented Mar 28, 2025

@mdessole Can you recover fitpanel.cxx and rebase PR?

@mdessole mdessole force-pushed the experimental-tut branch 2 times, most recently from 1cc63ea to f807e11 Compare March 28, 2025 13:00
Copy link
Member

@linev linev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While RHist class will be removed,
one of course should remove related code in RFitPanel and and RBrowser

@mdessole mdessole force-pushed the experimental-tut branch 2 times, most recently from 42ab320 to b093990 Compare April 3, 2025 10:18
@mdessole mdessole force-pushed the experimental-tut branch 2 times, most recently from 277232d to a62096c Compare April 7, 2025 12:54
@mdessole
Copy link
Contributor Author

Debian125 failure not related to code changes, merging.

@mdessole mdessole merged commit 683036c into root-project:master Apr 24, 2025
38 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants