[runtime-cxxmodules] Generate std_darwin.modulemap from active SDK #18235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devajithvs
force-pushed
the
dev.fix_modulemap
branch
from
99d0f91 to
ce8f69f
Compare
devajithvs
force-pushed
the
dev.fix_modulemap
branch
from
ce8f69f to
9c90a47
Compare
devajithvs
changed the title
Test Results 19 files 19 suites 4d 16h 15m 28s ⏱️ Results for commit 8dbc8fd. ♻️ This comment has been updated with latest results. |
devajithvs
force-pushed
the
dev.fix_modulemap
branch
3 times, most recently
from
b2344c3 to
725ea28
Compare
Dynamically extract and wrap the system modulemap from the active SDK in a top-level 'std' module Also remove 'std_ctype_h' module to break cyclic dependencies.
devajithvs
force-pushed
the
dev.fix_modulemap
branch
from
725ea28 to
8dbc8fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Dynamically extract and wrap the system modulemap from the active
SDK in a top-level 'std' module
Also remove 'std_ctype_h' module to break cyclic dependencies.
Fixes #18213 for good, in a potentially future proof way.
Changes or fixes:
Checklist:
This PR fixes #