[tmva][sofie] Add new operators with feedback from 1st NGT Hackathon #18348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 18 files 18 suites 3d 21h 0m 57s ⏱️ Results for commit 2d69bc3. ♻️ This comment has been updated with latest results. |
|
this is a draft, of course, but a comment about the commit messages: https://github.com/root-project/root/blob/master/CONTRIBUTING.md - please follow the guidelines. I propose to start with "[sofie]" when it's about SOFIE |
sanjibansg
force-pushed
the
sofie/operators
branch
from
b6d21ed to
df14e76
Compare
sanjibansg
force-pushed
the
sofie/operators
branch
from
df14e76 to
0fd683c
Compare
sanjibansg
force-pushed
the
sofie/operators
branch
from
0fd683c to
390df64
Compare
lmoneta
requested changes
Apr 16, 2025
There was a problem hiding this comment.
Thanks Sanjiban for the PR.
I see that the NOT operator is implemented as Neg, but it is not exactly the same. The NOT acts only on bool types. Currently Neg supports only Float. We should change this and have support for Boolean in ParseNeg in case it is a NOT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new operators to SOFIE based on the feedback we received from the 1st NGT Hackathon. Following are the missing operators that will be added: