Skip to content

[io] Prevent losing data due to SIGTERM (under Unix) #18403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ferdymercury
Copy link
Contributor

@ferdymercury ferdymercury commented Apr 14, 2025

This Pull request:

Changes or fixes:

Fixes #13300

  • I tested this locally on Ubu22 and it works fine.
  • I do not know how to properly test it using GTEST, I only found test_polling.cxx doing something like that but it looked too complicated, so I ended up simplifying.
  • I do not know if Windows must catch SIGTERM somewhere else @bellenot ?

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

Copy link

github-actions bot commented Apr 14, 2025

Test Results

    17 files      17 suites   4d 10h 19m 4s ⏱️
 2 738 tests  2 737 ✅ 0 💤 1 ❌
44 943 runs  44 942 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 03f2302.

♻️ This comment has been updated with latest results.

@bellenot
Copy link
Member

@ferdymercury The SIGILL and SIGTERM signals aren't generated under Windows. They're included for ANSI compatibility. See the signal reference

@ferdymercury ferdymercury changed the title [io] Prevent losing data due to SIGTERM [io] Prevent losing data due to SIGTERM (under Unix) Apr 22, 2025
@ferdymercury ferdymercury added this to the 6.38.00 milestone Apr 22, 2025
@bellenot bellenot assigned dpiparo and pcanal and unassigned bellenot Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test SIGTERM vs ~TFile
4 participants