[ntuple] Implement RField<TObject>::ReadInClusterImpl
#18405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 18 files 18 suites 4d 3h 5m 52s ⏱️ For more details on these failures, see this check. Results for commit 4686fed. ♻️ This comment has been updated with latest results. |
enirolf
approved these changes
Apr 15, 2025
jblomer
approved these changes
Apr 16, 2025
... in preparation of RField<TObject>::ReadInCluster
Otherwise RFieldBase::ReadInClusterImpl tries to use the principal column to translate to a global index, which results in a nullptr dereference. Fixes root-project#18404
hahnjo
force-pushed
the
ntuple-vector-TObject
branch
from
fd5dd4d to
4686fed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise
RFieldBase::ReadInClusterImpltries to use the principal column to translate to a global index, which results in anullptrdereference.Fixes #18404