Skip to content

[ntuple] Remove ROOT7 guard from RemoveRNTupleSubFields #18425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

[ntuple] Remove ROOT7 guard from RemoveRNTupleSubFields #18425

merged 1 commit into from
Apr 16, 2025
+2 −5

Conversation

silverweed
Copy link
Contributor

An ifdef guard was leftover from #18410

@silverweed silverweed self-assigned this Apr 16, 2025
@silverweed silverweed marked this pull request as draft April 16, 2025 12:17
vepadulano
vepadulano approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@silverweed silverweed marked this pull request as ready for review April 16, 2025 12:35
@dpiparo dpiparo merged commit 4b15883 into root-project:master Apr 16, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepadulano vepadulano vepadulano approved these changes

@hahnjo hahnjo Awaiting requested review from hahnjo

@dpiparo dpiparo Awaiting requested review from dpiparo

@enirolf enirolf Awaiting requested review from enirolf

@martamaja10 martamaja10 Awaiting requested review from martamaja10 martamaja10 is a code owner

Assignees

@silverweed silverweed

Labels
in:RDataFrame in:RNTuple
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silverweed @vepadulano @dpiparo