[json] improve roottest/io/json testing #18483
Conversation
linev
commented
Apr 23, 2025
linev
commented
- Generate dictionary for custom tested classes
- Load this library when running test macros
- Avoid multiple cling workarounds
- All ref files remains as is
1. Generate dictionary for custom tested classes 2. Load this library when running test macros 3. Avoid multiple cling workarounds 4. All ref files remains as is
| #else | ||
| void runSTL0() | ||
| { | ||
| gSystem->Load("libJsonTestClasses"); | ||
|
|
||
| TJsonEx7 ex7; |
There was a problem hiding this comment.
This is odd. The compilation by Cling of runSTL0 happens before the gSystem->Load is executed, so it looks like the test is relying on auto-loading of the library instead. Is that the intent? Does it still work when ROOT is compiled with runtime_cxxmodule=OFF?
There was a problem hiding this comment.
I guess, we will see it in CI
There was a problem hiding this comment.
All three macros - runSTL, runSTL0, runSTL1 - exercise different STL containers with len = 5, 0, 1.
Library only needed to get generated streamer infos - code should work in compiled and interpreter mode in same way.
Allows to correctly use single tests
Test Results 17 files 17 suites 4d 9h 29m 15s ⏱️ For more details on these failures, see this check. Results for commit 26078f8. ♻️ This comment has been updated with latest results. |
