Skip to content

Add oqsprovider and liboqs to whitelist to address CentOS 10 failure #18490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Apr 24, 2025

This Pull request:

Changes or fixes:

   5/1406 Test   #12: pyunittests-bindings-pyroot-pythonizations-pyroot-import-load-libs ............................***Failed    1.35 sec
test_import (import_load_libs.ImportLoadLibs.test_import)
Test libraries loaded after importing ROOT ... ERROR
======================================================================
ERROR: test_import (import_load_libs.ImportLoadLibs.test_import)
Test libraries loaded after importing ROOT
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/root-6.34.06/bindings/pyroot/pythonizations/test/import_load_libs.py", line 124, in test_import
    raise Exception('Found not whitelisted libraries after importing ROOT:' \
Exception: Found not whitelisted libraries after importing ROOT:
 - oqsprovider
 - liboqs
If the test fails with a library that is loaded on purpose, please add it to the whitelist.
----------------------------------------------------------------------
Ran 1 test in 1.188s
FAILED (errors=1)
CMake Error at /builddir/build/BUILD/root-6.34.06/cmake/modules/RootTestDriver.cmake:232 (message):
  error code: 1

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

   5/1406 Test   root-project#12: pyunittests-bindings-pyroot-pythonizations-pyroot-import-load-libs ............................***Failed    1.35 sec
test_import (import_load_libs.ImportLoadLibs.test_import)
Test libraries loaded after importing ROOT ... ERROR
======================================================================
ERROR: test_import (import_load_libs.ImportLoadLibs.test_import)
Test libraries loaded after importing ROOT
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/root-6.34.06/bindings/pyroot/pythonizations/test/import_load_libs.py", line 124, in test_import
    raise Exception('Found not whitelisted libraries after importing ROOT:' \
Exception: Found not whitelisted libraries after importing ROOT:
 - oqsprovider
 - liboqs
If the test fails with a library that is loaded on purpose, please add it to the whitelist.
----------------------------------------------------------------------
Ran 1 test in 1.188s
FAILED (errors=1)
CMake Error at /builddir/build/BUILD/root-6.34.06/cmake/modules/RootTestDriver.cmake:232 (message):
  error code: 1
@ferdymercury
Copy link
Contributor

Thanks!!

Unrelated: have you rechecked by chance if any of these issues https://github.com/root-project/root/issues?q=is%3Aissue%20state%3Aopen%20author%3Aellert gives a different result with master branch?

Copy link

Test Results

    17 files      17 suites   3d 15h 48m 41s ⏱️
 2 731 tests  2 730 ✅ 0 💤 1 ❌
45 261 runs  45 259 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 0e19064.

Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@guitargeek guitargeek merged commit d77dad9 into root-project:master Apr 29, 2025
17 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants