[cmake][Win][Ninja] Fix ninja build on Windows #18503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bellenot Can you expend the commit log to explain/remind (and/or refer to prior explanation) why these copy and not needed with Ninja on Windows. Merci. |
|
@pcanal with Ninja, there is no |
|
Go ahead an add a reminder of this fact to the commit log :) |
On Windows, with Ninja, there is no `$<CONFIG>` subdirectory
bellenot
force-pushed
the
fix-roottest-ninja-win
branch
from
6636f5f to
5ec494d
Compare
Test Results 18 files 18 suites 4d 3h 10m 13s ⏱️ Results for commit 5ec494d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.