Skip to content

meta: Prevent memory hoarding for GetClass("int") #18537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

pcanal
Copy link
Member

@pcanal pcanal commented Apr 28, 2025

Prevent memory hoarding for GetClass("int") or any other numerical types.

This addresses https://root-forum.cern.ch/t/repeatedly-mapping-branches-slowly-fills-memory/63412.
This fix #18536.

This relates to #9029 but does not solve it completely. It solves the sub-cases of #9029 where the typedef is known to TROOT::GetListOfTypes.

@pcanal pcanal requested a review from dpiparo as a code owner April 28, 2025 19:31
@pcanal pcanal self-assigned this Apr 28, 2025
@pcanal pcanal added this to the 6.38.00 milestone Apr 28, 2025
Copy link

github-actions bot commented Apr 28, 2025

Test Results

    18 files      18 suites   4d 2h 39m 10s ⏱️
 2 731 tests  2 731 ✅ 0 💤 0 ❌
47 765 runs  47 765 ✅ 0 💤 0 ❌

Results for commit f1f3538.

♻️ This comment has been updated with latest results.

Copy link
Member

@dpiparo dpiparo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. We'll need also the backport for 6.36 ideally.

@pcanal pcanal merged commit c8cab54 into root-project:master May 1, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TClass::GetClass hoards memory when called for numerical types
2 participants