-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[build] Update UNURAN to 1.11.0 #18747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Update UNURAN to 1.11.0 #18747
Conversation
Test Results 18 files 18 suites 3d 6h 56m 37s ⏱️ For more details on these failures, see this check. Results for commit a5276e6. ♻️ This comment has been updated with latest results. |
Update builtin to latest version, including a crucial fix introduced by commit unuran/unuran@8cb1dc4 which avoids the following build error visible with a GCC 15 build: ``` In file included from pinv.c:553: pinv_newton.ch: In function '_unur_pinv_newton_maxerror': pinv_newton.ch:581:9: error: too many arguments to function '_unur_pinv_cubic_hermite_is_monotone'; expected 0, have 4 581 | ! _unur_pinv_cubic_hermite_is_monotone(gen,ui,zi,xval)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~ pinv.c:443:12: note: declared here 443 | static int _unur_pinv_cubic_hermite_is_monotone(); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ pinv_newton.ch: At top level: pinv_newton.ch:669:1: error: conflicting types for '_unur_pinv_cubic_hermite_is_monotone'; have 'int(struct unur_gen *, double *, double *, double *)' 669 | _unur_pinv_cubic_hermite_is_monotone(struct unur_gen *gen, double *ui, double *zi, double *xval) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ pinv.c:443:12: note: previous declaration of '_unur_pinv_cubic_hermite_is_monotone' with type 'int(void)' 443 | static int _unur_pinv_cubic_hermite_is_monotone(); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` This also removes the need for a patch of the LCG build system https://gitlab.cern.ch/sft/lcgcmake/-/commit/7c93a4a2747d01333e739f67f43f7cd8c607dc34
88309ae
to
a47f69c
Compare
I'm curious @andresailer @vepadulano, why is ROOT on LCG using |
Hi @guitargeek , this seems to go back 12 years, I don't know why we started with it. We would like to avoid adding a dependency from our stack to ROOT so that downstream customers of ROOT don't have to adapt to find more external packages. |
The updated builtin doesn't seem to break any platform. I don't know what could be the cause of the Windows failures since this PR is not using the builtin on Windows. Before merging the last two commits will have to be removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, please remove the ci modifications before merging.
a5276e6
to
a2c86d3
Compare
@vepadulano , @dpiparo , Many thanks! |
Update builtin to latest version, including a crucial fix introduced by commit
unuran/unuran@8cb1dc4 which avoids the following build error visible with a GCC 15 build:
This also removes the need for a patch of the LCG build system https://gitlab.cern.ch/sft/lcgcmake/-/commit/7c93a4a2747d01333e739f67f43f7cd8c607dc34