Skip to content

[build] Update UNURAN to 1.11.0 #18747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vepadulano
Copy link
Member

Update builtin to latest version, including a crucial fix introduced by commit
unuran/unuran@8cb1dc4 which avoids the following build error visible with a GCC 15 build:

In file included from pinv.c:553:
pinv_newton.ch: In function '_unur_pinv_newton_maxerror':
pinv_newton.ch:581:9: error: too many arguments to function '_unur_pinv_cubic_hermite_is_monotone'; expected 0, have 4
  581 |       ! _unur_pinv_cubic_hermite_is_monotone(gen,ui,zi,xval))
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~
pinv.c:443:12: note: declared here
  443 | static int _unur_pinv_cubic_hermite_is_monotone();
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
pinv_newton.ch: At top level:
pinv_newton.ch:669:1: error: conflicting types for '_unur_pinv_cubic_hermite_is_monotone'; have 'int(struct unur_gen *, double *, double *, double *)'
  669 | _unur_pinv_cubic_hermite_is_monotone(struct unur_gen *gen, double *ui, double *zi, double *xval)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
pinv.c:443:12: note: previous declaration of '_unur_pinv_cubic_hermite_is_monotone' with type 'int(void)'
  443 | static int _unur_pinv_cubic_hermite_is_monotone();
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This also removes the need for a patch of the LCG build system https://gitlab.cern.ch/sft/lcgcmake/-/commit/7c93a4a2747d01333e739f67f43f7cd8c607dc34

Update builtin to latest version, including a crucial fix introduced by
commit
unuran/unuran@8cb1dc4
which avoids the following build error visible with a GCC 15 build:
```
In file included from pinv.c:553:
pinv_newton.ch: In function '_unur_pinv_newton_maxerror':
pinv_newton.ch:581:9: error: too many arguments to function '_unur_pinv_cubic_hermite_is_monotone'; expected 0, have 4
  581 |       ! _unur_pinv_cubic_hermite_is_monotone(gen,ui,zi,xval))
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~
pinv.c:443:12: note: declared here
  443 | static int _unur_pinv_cubic_hermite_is_monotone();
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
pinv_newton.ch: At top level:
pinv_newton.ch:669:1: error: conflicting types for '_unur_pinv_cubic_hermite_is_monotone'; have 'int(struct unur_gen *, double *, double *, double *)'
  669 | _unur_pinv_cubic_hermite_is_monotone(struct unur_gen *gen, double *ui, double *zi, double *xval)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
pinv.c:443:12: note: previous declaration of '_unur_pinv_cubic_hermite_is_monotone' with type 'int(void)'
  443 | static int _unur_pinv_cubic_hermite_is_monotone();
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

This also removes the need for a patch of the LCG build system
https://gitlab.cern.ch/sft/lcgcmake/-/commit/7c93a4a2747d01333e739f67f43f7cd8c607dc34
@vepadulano vepadulano requested a review from dpiparo May 16, 2025 13:00
@vepadulano vepadulano self-assigned this May 16, 2025
@vepadulano vepadulano requested a review from lmoneta as a code owner May 16, 2025 13:00
@vepadulano vepadulano added the clean build Ask CI to do non-incremental build on PR label May 16, 2025
@vepadulano vepadulano closed this May 16, 2025
@vepadulano vepadulano reopened this May 16, 2025
Copy link

github-actions bot commented May 16, 2025

Test Results

    17 files      17 suites   3d 6h 11m 49s ⏱️
 2 716 tests  2 716 ✅ 0 💤 0 ❌
45 727 runs  45 727 ✅ 0 💤 0 ❌

Results for commit 88309ae.

♻️ This comment has been updated with latest results.

@vepadulano vepadulano requested a review from bellenot as a code owner May 16, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean build Ask CI to do non-incremental build on PR in:Build System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant