[CMake] Discourage the use of soversion=ON
#18876
Conversation
This reverts commit f10e08e.
Discourage the use of `soversion=ON` because the rootmap files don't support it. Therefore, this option has no clear benefit. It seemingly allows you to have multiple ROOT versions in parallel on the system, by things will break anyway since e.g. the rootmap files are unversioned.
Co-authored-by: Bertrand Bellenot <[email protected]>
Test Results 19 files 19 suites 3d 8h 47m 18s ⏱️ Results for commit 06a16be. ♻️ This comment has been updated with latest results. |
|
Just to be clear - numbers in so-names makes the runtime environment much more stable. An application linked to ROOT X.Y.Z will not use libraries from ROOT X.Y.W. As for the |
Cross-link: https://its.cern.ch/jira/browse/ROOT-10151 |
|
Nice idea! If we have a way to proper version the rootmap files and others, we can definitely recommend the |
| @@ -158,7 +158,7 @@ ROOT_BUILD_OPTION(rpath ON "Link libraries with built-in RPATH (run-time search | |||
| ROOT_BUILD_OPTION(runtime_cxxmodules ON "Enable runtime support for C++ modules") | |||
| ROOT_BUILD_OPTION(shadowpw OFF "Enable support for shadow passwords") | |||
| ROOT_BUILD_OPTION(shared ON "Use shared 3rd party libraries if possible") | |||
| ROOT_BUILD_OPTION(soversion OFF "Set version number in sonames (recommended)") | |||
| ROOT_BUILD_OPTION(soversion OFF "Set version number in sonames for shared libraries. Not recommended, as the pcm and rootmap files are unversioned and always point to the non-versioned shared libraries.") | |||
There was a problem hiding this comment.
| ROOT_BUILD_OPTION(soversion OFF "Set version number in sonames for shared libraries. Not recommended, as the pcm and rootmap files are unversioned and always point to the non-versioned shared libraries.") | |
| ROOT_BUILD_OPTION(soversion OFF "Set version number in sonames for shared libraries. Not recommended, as the pcm and rootmap files do not (yet) support versioning and always point to the non-versioned shared libraries.") |
There was a problem hiding this comment.
Nice idea! If we have a way to proper version the rootmap files and others, we can definitely recommend the soversion=ON. But as long as this is not done by our build system, we can't recommend it.
It shouldn't be all that difficult to do with the current build system. Just install .rootmap in lib/, and include that directory in the system.rootrc as part of the DynamicPath setting. I believe ROOT looks for .rootmap files in that path and those set by some environment variable (not LD_LIBRARY_PATH, if I remember correctly).
Point is, you can do it tomorrow if you want. Better fix this in a proper way right away than keep pushing down the line.
Yours,
Christian
There was a problem hiding this comment.
in
lib/,
Should have been lib/<version>
There was a problem hiding this comment.
Of course, even better if it is in the code to load the .rootmap files.
Discourage the use of
soversion=ONbecause the rootmap files don'tsupport it. Therefore, this option has no clear benefit. It seemingly
allows you to have multiple ROOT versions in parallel on the system, by
things will break anyway since e.g. the rootmap files are unversioned.