[io] Add ROOT::Internal::DumpBin(TMemFile&) for debugging purposes #20628
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblomer
reviewed
Dec 3, 2025
Contributor
jblomer
left a comment
jblomer
left a comment
There was a problem hiding this comment.
Nice!
Perhaps better implemented as ROOT::Internal::DumpBin(TMemFile &) in order to not increase the public interface.
silverweed
force-pushed
the
tmemfile_dumpbin
branch
from
1d8c337 to
8eb21db
Compare
jblomer
approved these changes
Dec 3, 2025
silverweed
changed the title
Test Results 21 files 21 suites 3d 13h 54m 47s ⏱️ For more details on these failures, see this check. Results for commit 8eb21db. |
pcanal
reviewed
Dec 3, 2025
Comment on lines
+321
to
+323
| /// FILE *out = fopen("memfile_dump.root", "wb"); | ||
| /// ROOT::Internal::DumpBin(memFile, out); | ||
| /// fclose(out); |
Member
There was a problem hiding this comment.
What is the advantage of requiring the 3 steps instead of folding them into the function?
Contributor
Author
There was a problem hiding this comment.
Mostly the ability to pass stdout or similar, which would be more awkward to do with a string argument.
Also one may potentially want to dump multiple MemFiles to the same output, though that's probably rare.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
adds a method to
TMemFilethat allows to dump the current contents of the memory blocks to file. Differently fromCp, it does not modify the contents in any way, so it's useful/meant to be used for debugging.The doc comment clarifies that
Cpshould still be preferred for regular use cases.