[ntuple] fixes to subfield name handling #20629
Open
+129
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For fields that are constructed using existing item subfields, ensure that the subfields are called _0, _1, ... in the final type. This issue has been addressed for untyped collections only in commit bdce4b5 The issue is, however, present in many other field constructors, too.
In RFieldZero and RRecordField, check that the passed subfields have pairwise distinct names.
Test Results 22 files 22 suites 4d 5h 50m 55s ⏱️ Results for commit e8d96e7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following two fixes to the treatment of subfield names: