[ntuple] add support for leaf count arrays in classes #20633
+351
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblomer
force-pushed
the
ntuple-leafcount-class
branch
from
57e7292 to
614cc6c
Compare
New field for internal use: maps an on-disk collection to a leaf count array in a class. Writes RVec collection. Must only be used inside a class field.
Maps leaf count arrays in classes to RVecs using Internal::RLeafCountArrayField
Test Results 20 files 20 suites 3d 15h 42m 21s ⏱️ For more details on these failures, see this check. Results for commit 614cc6c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transparently translates a leaf count array in a custom class in an RVec (read & write). Classes with leaf count arrays are used, e.g., in the ALICE RAW EDM but most likely there are other relevant cases, too.
Since this approach diverges the in-memory representation from the on-disk representation, we should discuss if we actually want this.
In any case, we probably want the first commit that detects leaf count arrays in classes and fails gracefully in such a case.