Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 5, 2025

This Pull request:

Changes or fixes:

This PR can be closed. The backport has been completed manually by @pcanal.

This PR was opened against master instead of the patch branches, which was not useful since master already had the fix from PR #20645. The Copilot agent environment cannot create separate PRs targeting different branches.

Backport status (completed by @pcanal):

  • v6-38-00-patches: c5822aa
  • v6-36-00-patches: 4bcab64
  • v6-34-00-patches: d2a42e0

All three patch branches now have the fix for thisroot.sh that properly removes previous ROOT version from paths.

Checklist:

  • tested changes locally
  • updated the docs (if necessary)
Original prompt

This section details on the original issue you should resolve

<issue_title>Backport #20645</issue_title>
<issue_description>We need to backport #20645 to the v6-38-00-patches, v6-36-00-patches and v6-34-00-patches branches to fully resolve #20643.</issue_description>

<agent_instructions>Do not close this issue until all 3 branches have been updated.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Dec 5, 2025
@pcanal pcanal self-requested a review December 5, 2025 18:51
Copilot AI changed the title [WIP] Backport changes from PR 20645 to multiple branches [WIP] Backport thisroot.sh fix (PR #20645) - Manual action required Dec 5, 2025
@pcanal
Copy link
Member

pcanal commented Dec 5, 2025

@copilot that was not very useful. Why did you open this PR against the wrong repository?

Copy link
Contributor Author

Copilot AI commented Dec 5, 2025

@copilot that was not very useful. Why did you open this PR against the wrong repository?

You're right - apologies for the confusion. My environment doesn't allow me to create PRs targeting different branches, so this PR was created against master (which already had the fix).

I see that you've already completed the backports manually to all three branches:

  • v6-38-00-patches: c5822aa
  • v6-36-00-patches: 4bcab64
  • v6-34-00-patches: d2a42e0

This PR can be closed - the backport task is complete.

Copilot AI changed the title [WIP] Backport thisroot.sh fix (PR #20645) - Manual action required [CLOSED] Backport thisroot.sh fix (PR #20645) - Already completed manually Dec 5, 2025
@pcanal
Copy link
Member

pcanal commented Dec 5, 2025

Side note: the backport were done using Copilot/Claude in VSCode which also made a mistake and pushed the backport directly into the patch branches :( ....

@pcanal pcanal closed this Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backport https://github.com/root-project/root/pull/20645 thisroot.sh no longer remove previous version from the paths

2 participants