[cling] Recognize Mach-O bundles as shared libraries on macOS [v6.36] #20881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add file_magic::macho_bundle to the list of recognized shared library types in isSharedLibrary(). This allows Cling to correctly identify and load Mach-O bundle files, which are produced by CMake's MODULE library type. Without this fix, external dictionary libraries built as bundles (MH_BUNDLE) fail to load on macOS, while the same libraries built as dylibs (MH_DYLIB) work correctly. This is because lookupLibrary() uses isSharedLibrary() to validate library files, and bundles were incorrectly rejected. (cherry picked from commit 2ef9dbb)
Test Results 18 files 18 suites 3d 2h 19m 26s ⏱️ Results for commit 41cc44d. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
file_magic::macho_bundleto the list of recognized shared library types inisSharedLibrary(). This allows Cling to correctly identify and load Mach-O bundle files, which are produced by CMake'sMODULElibrary type.Without this fix, external dictionary libraries built as bundles (
MH_BUNDLE) fail to load on macOS, while the same libraries built as dylibs (MH_DYLIB) work correctly. This is becauselookupLibrary()usesisSharedLibrary()to validate library files, and bundles were incorrectly rejected.(cherry picked from commit 2ef9dbb)
Backport of PR #20861, FYI @chrisburr