Cleanups across ROOT before disabling the auto registration of TEventList#22896
Open
hageboeck wants to merge 4 commits into
Open
Cleanups across ROOT before disabling the auto registration of TEventList#22896hageboeck wants to merge 4 commits into
hageboeck wants to merge 4 commits into
Conversation
hageboeck
requested review from
bellenot,
dpiparo,
guitargeek,
jblomer,
lmoneta and
pcanal
as code owners
July 23, 2026 07:20
1 task
dpiparo
approved these changes
Jul 23, 2026
Test Results 23 files 23 suites 3d 18h 6m 13s ⏱️ For more details on these failures, see this check. Results for commit adbe15b. ♻️ This comment has been updated with latest results. |
hageboeck
force-pushed
the
TEventList_cleanup
branch
from
July 23, 2026 12:03
d7ed9e0 to
5d7c569
Compare
Fixtures run even when the setup test is not selected, whereas dependencies only have an effect when setup and main test are selected.
Also remove further includes that were unused.
- Remove unused headers. - Use member initialisers to clean up constructors. - Apply clang-tidy/clang-format fixes for member init.
hageboeck
force-pushed
the
TEventList_cleanup
branch
from
July 24, 2026 07:46
5d7c569 to
adbe15b
Compare
jblomer
approved these changes
Jul 24, 2026
Comment on lines
63
to
66
| if (initsize > 100) fSize = initsize; | ||
| else fSize = 100; | ||
| if (delta > 100) fDelta = delta; | ||
| else fDelta = 100; |
Contributor
There was a problem hiding this comment.
Should this become
fSize = std::max(fSize, initsize);
fDelta = std::max(fDelta, delta);
| else fSize = 100; | ||
| if (delta > 100) fDelta = delta; | ||
| else fDelta = 100; | ||
| fList = nullptr; |
| for (Int_t i=0; i<fN; i++) | ||
| fList[i] = list.fList[i]; | ||
| fReapply = list.fReapply; | ||
| fDirectory = nullptr; |
|
|
||
| for (Int_t i=0; i<fN; i++) | ||
| fList[i] = list.fList[i]; | ||
| fReapply = list.fReapply; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of working on the auto-registration of TEventList (#22817), several cleanups were possible: