Skip to content

[WIP][GSoC] CNN3D and MaxPool3D implementation for GSoC 2020 #6263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

surya2191997
Copy link
Contributor

@surya2191997 surya2191997 commented Aug 27, 2020

[Work Product] This pull request contains the code pertaining to the Google Summer of Code 2020 project Development of 3D CNN in TMVA. It implements the following features:

  • 3D CNN layer for cpu and and tests for the same
  • 3D MaxPool layer for cpu and tests for the same

Implementation for CUDA architecture is still WIP. The last commit is Added backward pass tests(1b82793). These features are yet to be merged. Detailed updates can be found on my blog post.

@phsft-bot
Copy link

Can one of the admins verify this patch?

@surya2191997 surya2191997 changed the title CNN3D and MaxPool3D implementation for GSoC 2020 [WIP][GSoC]CNN3D and MaxPool3D implementation for GSoC 2020 Aug 27, 2020
@surya2191997 surya2191997 changed the title [WIP][GSoC]CNN3D and MaxPool3D implementation for GSoC 2020 [WIP][GSoC] CNN3D and MaxPool3D implementation for GSoC 2020 Aug 27, 2020
@lmoneta lmoneta self-assigned this Aug 27, 2020
@lmoneta
Copy link
Member

lmoneta commented Aug 27, 2020

@phsft-bot build

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos7-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac1015/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-ubuntu16/nortcxxmod.
Running on sft-ubuntu-1604-3.cern.ch:/build/workspace/root-pullrequests-build
See cdash.
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See cdash.
See console output.

@lmoneta
Copy link
Member

lmoneta commented Sep 2, 2020

Hi Suryia,
this PR does not build when cuda is enables (tmva-gpu=On).
Can you please apply this patch to fix this:
https://cernbox.cern.ch/index.php/s/ZB4ij5to248um6u

Thank you

Lorenzo

@surya2191997
Copy link
Contributor Author

Hi Suryia,
this PR does not build when cuda is enables (tmva-gpu=On).
Can you please apply this patch to fix this:
https://cernbox.cern.ch/index.php/s/ZB4ij5to248um6u

Thank you

Lorenzo

Thanks for the patch Lorenzo, I've updated the PR

shoaibahmed added a commit to shoaibahmed/root that referenced this pull request Apr 2, 2021
shoaibahmed added a commit to shoaibahmed/root that referenced this pull request Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants