-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[dictgen] Also forward declare namespaces, typedefs, enums: #8661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[dictgen] Also forward declare namespaces, typedefs, enums: #8661
Conversation
Starting build on |
They were picked up as side effects of classes, but not forward declared as and by themselves. This fixes namespaces and enums not being available / known at the ROOT prompt despite their dictionary being loaded: https://root-forum.cern.ch/t/enum-in-namespace-not-available-after-loading-dictionary/45757
e50d397
to
22a84ec
Compare
Starting build on |
Build failed on ROOT-ubuntu16/nortcxxmod. Failing tests:
And 78 more |
Build failed on ROOT-performance-centos8-multicore/default. Failing tests:
|
Build failed on mac1014/python3. Failing tests:
|
Build failed on mac11.0/cxx17. Failing tests:
|
Build failed on ROOT-debian10-i386/cxx14. Errors:
Failing tests:
|
Build failed on windows10/cxx14. Failing tests:
|
Restarted all tests to see how we are performing... |
Test Results 13 files 13 suites 2d 20h 31m 10s ⏱️ For more details on these failures, see this check. Results for commit 22a84ec. |
They were picked up as side effects of classes, but not forward declared as
and by themselves. This fixes namespaces and enums not being available / known at the ROOT prompt despite their dictionary being loaded:
https://root-forum.cern.ch/t/enum-in-namespace-not-available-after-loading-dictionary/45757