Skip to content

[dictgen] Also forward declare namespaces, typedefs, enums: #8661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Axel-Naumann
Copy link
Member

@Axel-Naumann Axel-Naumann commented Jul 13, 2021

They were picked up as side effects of classes, but not forward declared as
and by themselves. This fixes namespaces and enums not being available / known at the ROOT prompt despite their dictionary being loaded:
https://root-forum.cern.ch/t/enum-in-namespace-not-available-after-loading-dictionary/45757

@Axel-Naumann Axel-Naumann self-assigned this Jul 13, 2021
@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

They were picked up as side effects of classes, but not forward declared as
and by themselves. This fixes namespaces and enums not being available / known
at the ROOT prompt despite their dictionary being loaded:
https://root-forum.cern.ch/t/enum-in-namespace-not-available-after-loading-dictionary/45757
@Axel-Naumann Axel-Naumann force-pushed the dict-fwd-decl-ns-td-enum branch from e50d397 to 22a84ec Compare July 13, 2021 14:07
@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-debian10-i386/cxx14.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2021-07-13T15:46:23.191Z] stderr: error: could not read '.git/rebase-apply/head-name': No such file or directory

Failing tests:

@dpiparo
Copy link
Member

dpiparo commented Jun 24, 2024

Restarted all tests to see how we are performing...

Copy link

Test Results

    13 files      13 suites   2d 20h 31m 10s ⏱️
 2 648 tests  2 342 ✅ 0 💤 306 ❌
32 608 runs  31 946 ✅ 0 💤 662 ❌

For more details on these failures, see this check.

Results for commit 22a84ec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants