Conversation
Reading a data from a file in the 'data-raw' directory failed so a representation of the data for the test are created in situ.
Create an object of class `dist` which is a distance matrix of the kilometre distances (by road) between the State capitals of Nigeria. The scripts for generating the data are in situ.
I forgot to render the github_document from the RMD and this led to merge conflicts.
I changed my mind about testing the reading of phone numbers from Excel spreadsheets, which notoriously removes leading zeros. Instead, the test data are stored in RDS format, and retrievable as a data frame. Also, while implementing the fix, it was discovered that the help file needed some adjustment, to provide clarity on the input expected by the function (`fix_mobile`).
Fixed the error that alerted to the deprecation of the value "package" used in the directove @doctype, and updating it to the now correct value of "_Package".
I used `usethis::use_package_doc()` to resolve this issue.
Added alt-text to generated/placed images where appropriate.
Removed the references to the {lifecycle} functions that were used to
indicate function arguments that were marked for deprecation in version
0.5. Also I decided to rename one of the non-exported helper functions.
Due to an error encountered during R CMD check.
Also bump the dev version
Apply sorting to individual element of LGA lists.
Will, of course be excluded from build.
While trying to fix an issue with building the vignette during R CMD
check, I noticed that there were some code artefacts that were useless,
that were leftovers from the time the package was ported from `{sp}` to
`{sf}`. This was cleaned up will all tests passing. The issue that drew
my attention to this is, however, yet to be fixed.
The problem was identified as wrong dispatch for `[.sf` as there was no import for the packages functions in NAMESPACE (I had earlier decided to use all the functions via `::`). Once addressed, the build proceeded normally. Addiitional minor changes were made like advancing the copyright period to the current year 2026.
The package was archived on CRAN a few weeks ago, and will therefore have to review the internal setup files that were using it i.e. the file on LGA data.
Used a more maintainable coding approach to creating the `ngdist` object, as there are plans to extend it beyond the State Capitals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See
NEWS.mdfor changes attributed to v0.7.0.