Conversation
ref: discussion with Robin + osminfra
Member
|
This looks good to me, I think it makes sense to have it in there. Note, we'll probably need to change the function, specifically, the inclusion of footway was not right. That will be fixed in this small change: #225 |
Member
|
Note the updated definitions here, there are many different ways to define a cycleway! |
Update get-network.R
Contributor
Author
👍
I think it should be pretty easy to copy those definitions here and adjust the docs (with links maybe) documenting the new types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New definitions are taken from osminfra package. For example:
Created on 2021-08-24 by the reprex package (v2.0.0)
I'm not sure about all details behind those definitions, but, if you want, I can complete the PR and add all new types.
cc @Robinlovelace and @joeytalbot