Fix configure adding trailing space to PKG_CPPFLAGS each run#34
Open
trevorld wants to merge 1 commit intoropensci:masterfrom
Open
Fix configure adding trailing space to PKG_CPPFLAGS each run#34trevorld wants to merge 1 commit intoropensci:masterfrom
trevorld wants to merge 1 commit intoropensci:masterfrom
Conversation
When `pkg-config --cflags libjpeg` returns empty (standard include path), the sed substitution was replacing `-Ilibqpdf` with `-Ilibqpdf `, adding a trailing space. Guard the sed calls so they only run when the flags are non-empty. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg-config --cflags libjpegreturns empty (standard include path), the sed substitution was replacing-Ilibqpdfwith-Ilibqpdfwhich adds a trailing space tosrc/Makevarsevery single time you rundevtools::load_all().