preparing for CRAN release 3.8.2 #783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
May 21, 2025 12:55
There was a problem hiding this comment.
Pull Request Overview
Prepares the package for CRAN release 3.8.2 by bumping version metadata, adding new download features, fixing URL encoding, updating docs, and refreshing test fixtures.
- Bump package version to 3.8.2 and update DESCRIPTION, NEWS.md, codemeta.json, and cran-comments.md
- Add support for SQL descriptor in
occ_download_describe(), addinstitutionKeypredicate in download DSL, and fix URL encoding inname_backbone_checklist() - Update test fixtures’ timestamps and payloads for new DOIs/counts; adjust CI workflows and ignore patterns
Reviewed Changes
Copilot reviewed 160 out of 160 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/fixtures/*.yml | Updated recorded_at timestamps, base64 payloads, and DOIs/counts |
| man/occ_download_describe.Rd | Added "sql" as a supported descriptor type |
| man/download_predicate_dsl.Rd | Documented new institutionKey predicate |
| R/name_backbone_checklist.R | Switched to encoding individual query parameters; removed full-URL encode |
| R/download_predicate_dsl.R | Added institutionKey → "INSTITUTION_KEY" mapping |
| DESCRIPTION, NEWS.md, codemeta.json, cran-comments.md | Bumped package version and updated release notes and metadata |
| .github/workflows/*.yaml | Updated Ubuntu runners and GitHub Actions versions |
| .Rbuildignore, .github/.gitignore | Added ignore rules for .github directory and HTML files |
Comments suppressed due to low confidence (2)
R/name_backbone_checklist.R:250
- [nitpick] Remove the commented-out full URL encoding line to avoid confusion, since individual parameters are already encoded above.
urls <- sapply(urls,function(x) utils::URLencode(x))
R/download_predicate_dsl.R:512
- Add unit tests for the new 'institutionKey' predicate to verify that it produces the correct query parameter in the DSL.
institutionKey = "INSTITUTION_KEY",
| vignettes/ | ||
| ^LICENSE\.md$ | ||
| ^CRAN-SUBMISSION$ | ||
| ^\.github$ |
There was a problem hiding this comment.
Use a pattern like '^\.github/' to ignore the entire .github directory rather than only a file or folder named exactly '.github'.
Suggested change
| ^\.github$ | |
| ^\.github/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW FEATURES
occ_download_doi()accepts a GBIF download DOI and returns the download key. (#743)occ_download()now supports download viainstitutionKey. (#785)BUG FIXES
Fixed double import bug in
occ_download_import(). (#765)Fixed URL encoding bug in
name_backbone_checklist(). (#784)DOCUMENTATION
Several small improvements to the docs. (#777) (#776) (#773) (#763) (#758)