Skip to content

Conversation

@jhnwllr
Copy link
Collaborator

@jhnwllr jhnwllr commented Jan 16, 2026

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for downloading GBIF occurrence data using alternative taxonomies (specifically Catalogue of Life XR) by introducing a checklistKey parameter to the pred() function.

Changes:

  • Added checklistKey parameter to pred() function for specifying alternative taxonomies
  • Added validation to ensure checklistKey is only used with taxonKey predicates and is a valid UUID
  • Updated documentation and added vignette section explaining the new functionality

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
DESCRIPTION Version bump from 3.8.4.4 to 3.8.4.5
R/download_predicate_dsl.R Added checklistKey parameter to pred() with validation logic
man/download_predicate_dsl.Rd Documentation for new checklistKey parameter
man/occ_download.Rd Clarified verbatim_extensions documentation
vignettes/getting_occurrence_data.Rmd Added section explaining alternative taxonomy downloads
tests/testthat/test-occ_download.R Added tests for checklistKey functionality
tests/testthat/test-download_parsing.R Added test for parse_predicates with checklistKey
tests/fixtures/* Updated test fixtures with new download keys and dates

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


occ_download(
pred("taxonKey", "Q2M4"),
checklistKey = "7ddf754f-d193-4cc9-b351-99906754a03b",
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checklistKey parameter should be passed to the pred() function, not to occ_download(). The occ_download() function does not have a checklistKey parameter. This code example will fail because occ_download() does not accept checklistKey as a parameter.

Suggested change
checklistKey = "7ddf754f-d193-4cc9-b351-99906754a03b",
pred("checklistKey", "7ddf754f-d193-4cc9-b351-99906754a03b"),

Copilot uses AI. Check for mistakes.
@jhnwllr jhnwllr merged commit 0485c20 into master Jan 16, 2026
7 checks passed
@jhnwllr jhnwllr deleted the feature/checklistkey-downloads branch January 16, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants