Replace deprecated spin_some in realtime_tools (backport #448) #451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR replaces uses of the deprecated rclcpp::spin_some(node) with rclcpp::executors::SingleThreadedExecutor in the realtime tools tests, addressing issue #411
What changed
Files changed are:
Notes for Reviewer
Happy to make any changes that are requested. Please also double check my approach with the spin_some() usage in the TEST(RealtimeServerGoalHandle, set_canceled) test.
This is an automatic backport of pull request #448 done by Mergify.