Skip to content

Conversation

@mergify
Copy link

@mergify mergify bot commented Nov 4, 2025

Overview

This PR replaces uses of the deprecated rclcpp::spin_some(node) with rclcpp::executors::SingleThreadedExecutor in the realtime tools tests, addressing issue #411

What changed

Files changed are:

  • realtime_tools/test/realtime_server_goal_handle_tests.cpp
  • realtime_tools/test/realtime_publisher_tests.cpp

Notes for Reviewer

Happy to make any changes that are requested. Please also double check my approach with the spin_some() usage in the TEST(RealtimeServerGoalHandle, set_canceled) test.


This is an automatic backport of pull request #448 done by Mergify.

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.44%. Comparing base (47d4779) to head (91b82ab).
⚠️ Report is 1 commits behind head on kilted.

Files with missing lines Patch % Lines
...e_tools/test/realtime_server_goal_handle_tests.cpp 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           kilted     #451      +/-   ##
==========================================
+ Coverage   85.34%   85.44%   +0.10%     
==========================================
  Files          17       17              
  Lines        1440     1450      +10     
  Branches      135      135              
==========================================
+ Hits         1229     1239      +10     
  Misses        122      122              
  Partials       89       89              
Flag Coverage Δ
unittests 85.44% <87.50%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
realtime_tools/test/realtime_publisher_tests.cpp 88.88% <100.00%> (+0.31%) ⬆️
...e_tools/test/realtime_server_goal_handle_tests.cpp 92.80% <84.61%> (+0.43%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 9a1e1a4 into kilted Nov 4, 2025
13 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/kilted/pr-448 branch November 4, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants