Remove the dangling param flag for robot_description fom ROS parameters (#2115)

saikishor · web-flow · commit d7b0af682ddb · 2025-03-19T13:23:30.000+01:00
diff --git a/controller_manager/src/controller_manager.cpp b/controller_manager/src/controller_manager.cpp
@@ -3828,7 +3828,9 @@ rclcpp::NodeOptions ControllerManager::determine_controller_node_options(
     {
       if (
         node_options_arguments.back() == RCL_REMAP_FLAG ||
-        node_options_arguments.back() == RCL_SHORT_REMAP_FLAG)
+        node_options_arguments.back() == RCL_SHORT_REMAP_FLAG ||
+        node_options_arguments.back() == RCL_PARAM_FLAG ||
+        node_options_arguments.back() == RCL_SHORT_PARAM_FLAG)
       {
         node_options_arguments.pop_back();
       }

Original file line number	Diff line number	Diff line change
`@@ -3828,7 +3828,9 @@ rclcpp::NodeOptions ControllerManager::determine_controller_node_options(`
`3828`	`3828`	`{`
`3829`	`3829`	`if (`
`3830`	`3830`	`node_options_arguments.back() == RCL_REMAP_FLAG \|\|`
`3831`		`- node_options_arguments.back() == RCL_SHORT_REMAP_FLAG)`
	`3831`	`+ node_options_arguments.back() == RCL_SHORT_REMAP_FLAG \|\|`
	`3832`	`+ node_options_arguments.back() == RCL_PARAM_FLAG \|\|`
	`3833`	`+ node_options_arguments.back() == RCL_SHORT_PARAM_FLAG)`
`3832`	`3834`	`{`
`3833`	`3835`	`node_options_arguments.pop_back();`
`3834`	`3836`	`}`