Skip to content

Create an issue if build_*_workspace output is nonzero#761

Merged
christophfroehlich merged 2 commits into
masterfrom
ici-issue
May 7, 2026
Merged

Create an issue if build_*_workspace output is nonzero#761
christophfroehlich merged 2 commits into
masterfrom
ici-issue

Conversation

@christophfroehlich
Copy link
Copy Markdown
Member

@christophfroehlich christophfroehlich commented Apr 29, 2026

https://github.com/ros-controls/ros2_control_ci/actions/runs/25090920855/job/73516695917
build fails, but with return code 1

'build_target_workspace' returned with code '1' after 0 min 38 sec

An issue should be created for any nonzero return code?

Copy link
Copy Markdown
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at #29 (comment) it seems that it was intentional back then, that we didn't create an issue on dependency installation failures.

@christophfroehlich
Copy link
Copy Markdown
Member Author

yes, but this isn't touched by this PR as it is a different step (see install_target_dependencies in the linked CI run). I only changed it to open an issue if build_target_workspace is nonzero instead of exactly "2", but I haven't analyzed what was the rationale behind that.

@fmauch
Copy link
Copy Markdown
Contributor

fmauch commented May 7, 2026

Sorry, the dependency installation was wrong. The rationale behind the two is actually make's return code: https://www.gnu.org/software/make/manual/html_node/Running.html

I guess, the difference is that in the linked PR cmake actually throws an error and not make. I guess, going the >0 route should be fine.

@christophfroehlich christophfroehlich merged commit 614d4c6 into master May 7, 2026
25 of 27 checks passed
@christophfroehlich christophfroehlich deleted the ici-issue branch May 7, 2026 10:30
@github-project-automation github-project-automation Bot moved this from Needs review to Done in Review triage May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants