Create an issue if build_*_workspace output is nonzero#761
Conversation
fmauch
left a comment
There was a problem hiding this comment.
Looking at #29 (comment) it seems that it was intentional back then, that we didn't create an issue on dependency installation failures.
|
yes, but this isn't touched by this PR as it is a different step (see install_target_dependencies in the linked CI run). I only changed it to open an issue if build_target_workspace is nonzero instead of exactly "2", but I haven't analyzed what was the rationale behind that. |
|
Sorry, the dependency installation was wrong. The rationale behind the two is actually make's return code: https://www.gnu.org/software/make/manual/html_node/Running.html I guess, the difference is that in the linked PR cmake actually throws an error and not make. I guess, going the >0 route should be fine. |
https://github.com/ros-controls/ros2_control_ci/actions/runs/25090920855/job/73516695917
build fails, but with return code 1
An issue should be created for any nonzero return code?