Open
Conversation
github-actions
bot
requested review from
MarqRazz,
aprotyas,
arne48,
destogl and
mamueluth
saikishor
force-pushed
the
allow/parsing_param_files/spawner
branch
from
a79a52b to
8bf86b7
Compare
This was referenced Mar 25, 2026
destogl
approved these changes
Mar 28, 2026
Member
There was a problem hiding this comment.
can we remove this and add it directly to launch? As it is so short? And basically there are no myna parameters for CM - so probably adding from launch files might be better for simplicity.
Comment on lines
43
to
47
| parameters=[ | ||
| PathSubstitution(FindPackageShare("ros2_control_demo_example_1")) | ||
| / "config" | ||
| / "rrbot_controllers.yaml" | ||
| / "controller_manager.yaml" | ||
| ], |
Member
There was a problem hiding this comment.
Simple as that:
parameters=[{"update_rate": 10}]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.