Add GPSBroadcaster#1554
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1554 +/- ##
==========================================
+ Coverage 85.16% 85.17% +0.01%
==========================================
Files 123 126 +3
Lines 11755 11907 +152
Branches 996 999 +3
==========================================
+ Hits 10011 10142 +131
- Misses 1431 1451 +20
- Partials 313 314 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
left a comment
There was a problem hiding this comment.
Thank you for this new controller. I've found some on quick look
I'll send more reviews during this week.
gps_sensor_broadcaster/include/gps_sensor_broadcaster/gps_sensor_broadcaster.hpp
Outdated
Show resolved
Hide resolved
|
Conceptual question: We also have battery_state_broadcaster. Now we get a Now I can imagine we get a lot of future PR's creating packages for all items in this list: sensor_msgs. Would it make sense to template this such that we can simply send any message from sensor_msgs? |
|
@Timple Perhaps you're right; it could be a template class. However, since all sensors would use a different set of state interfaces, we would probably need to create a bunch of new semantic components (which can be done). Also, it looks like this decision was already settled. We've got pose/IMU/range broadcasters, and templating them would affect existing configs. |
christophfroehlich
left a comment
There was a problem hiding this comment.
Thanks for the follow-up to the semantic component. But I have some comments
btw: To fix the docs workflow, please add the userdoc.rst here.
gps_sensor_broadcaster/include/gps_sensor_broadcaster/gps_sensor_broadcaster.hpp
Show resolved
Hide resolved
d1349e1
into
ros-controls:master
As in the title. I'm open to any suggestions.