Skip to content

Fix the ActivateWithWrongJointsNamesFails test#1570

Merged
saikishor merged 3 commits intomasterfrom
fix/velocity_controller_test
Mar 4, 2025
Merged

Fix the ActivateWithWrongJointsNamesFails test#1570
saikishor merged 3 commits intomasterfrom
fix/velocity_controller_test

Conversation

@christophfroehlich
Copy link
Copy Markdown
Member

It came up with the fix introduced with #1568

@christophfroehlich
Copy link
Copy Markdown
Member Author

@Mergifyio backport mergify/bp/humble/pr-1568

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 4, 2025

backport mergify/bp/humble/pr-1568

✅ Backports have been created

Details

saikishor
saikishor previously approved these changes Mar 4, 2025
@saikishor
Copy link
Copy Markdown
Member

@christophfroehlich thanks for taking care of the fix

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (fc56126) to head (717e013).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1570      +/-   ##
==========================================
- Coverage   84.78%   84.75%   -0.03%     
==========================================
  Files         124      124              
  Lines       11439    11441       +2     
  Branches      963      965       +2     
==========================================
- Hits         9698     9697       -1     
+ Misses       1433     1432       -1     
- Partials      308      312       +4     
Flag Coverage Δ
unittests 84.75% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ollers/test/test_joint_group_effort_controller.cpp 98.43% <ø> (ø)
...lers/test/test_joint_group_position_controller.cpp 98.36% <ø> (ø)
...lers/test/test_joint_group_velocity_controller.cpp 98.43% <ø> (ø)

... and 5 files with indirect coverage changes

Copy link
Copy Markdown
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for follow-up

@saikishor saikishor merged commit 11ed083 into master Mar 4, 2025
20 of 25 checks passed
@saikishor saikishor deleted the fix/velocity_controller_test branch March 4, 2025 11:57
mergify bot pushed a commit that referenced this pull request Mar 4, 2025
christophfroehlich added a commit that referenced this pull request Mar 4, 2025
)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich pushed a commit that referenced this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants