[mecanum_drive_controller] Fix Odometry Initialization (backport #1573)#1583
Merged
christophfroehlich merged 1 commit intohumblefrom Mar 11, 2025
Merged
[mecanum_drive_controller] Fix Odometry Initialization (backport #1573)#1583christophfroehlich merged 1 commit intohumblefrom
christophfroehlich merged 1 commit intohumblefrom
Conversation
(cherry picked from commit b333def)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where the odometry object wasn't initialized properly in the mecanum_drive_controller. The odometry_.init() call was missing, which the
base_frame_offset_could contain random values, leading to incorrect calculations in the transformation matrix. Specifically, this affects the line:and causes
velocity_in_base_frame_linear_xandvelocity_in_base_frame_linear_yto grow unbound. A test case was added to guard against this issue.This is an automatic backport of pull request #1573 done by Mergify.