Remove deprecated feedforward parameter+service#1753
Merged
christophfroehlich merged 2 commits intoros-controls:masterfrom Jun 11, 2025
Merged
Remove deprecated feedforward parameter+service#1753christophfroehlich merged 2 commits intoros-controls:masterfrom
christophfroehlich merged 2 commits intoros-controls:masterfrom
Conversation
github-actions
bot
requested review from
anfemosa,
arne48,
destogl,
fmauch,
mcbed,
moriarty and
saikishor
christophfroehlich
requested changes
Jun 10, 2025
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Can you please remove changes due to optionals? For consistency, we have a long going PR in fixing them all at once: #1566
pascalau
force-pushed
the
deprecate_enable_ff
branch
from
3575b89 to
21fd458
Compare
Contributor
Author
|
Sorry was not aware of the other PR. Should be fixed now. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1753 +/- ##
==========================================
- Coverage 86.29% 86.23% -0.07%
==========================================
Files 123 123
Lines 11941 11890 -51
Branches 995 993 -2
==========================================
- Hits 10305 10253 -52
- Misses 1333 1336 +3
+ Partials 303 301 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christophfroehlich
approved these changes
Jun 10, 2025
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Thanks, this LGTM!
Juliaj
approved these changes
Jun 10, 2025
Contributor
Juliaj
left a comment
Juliaj
left a comment
There was a problem hiding this comment.
LGTM. Demo example_16 (https://github.com/ros-controls/ros2_control_demos/tree/master/example_16) needs to be updated correspondingly.
8 tasks
christophfroehlich
changed the title
saikishor
approved these changes
Jun 11, 2025
christophfroehlich
merged commit 63448a3
into
ros-controls:master
20 of 27 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates the marked service and parameter from #1553. Also adopts tests and fixes compiler warning of the package due to optionals.