Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 10, 2025

Reviewed tests and deprecation warnings due to controller_interface update for the issue #1946
Modified the warning tests in the following packages;-

  1. ackermann_steering_controller
  2. admittance_controller
  3. bicycle_steering_controller
  4. chained_filter_controller
  5. diff_drive_controller
  6. effort_controllers
  7. force_torque_sensor_broadcaster
  8. forward_command_controller
  9. gpio_controllers
  10. gps_sensor_broadcaster
  11. imu_sensor_broadcaster
  12. joint_state_broadcaster
  13. joint_trajectory_controller
  14. mecanum_drive_controller
  15. motion_primitives_controllers
  16. omni_wheel_drive_controller
  17. parallel_gripper_controller
  18. pid_controller
  19. pose_broadcaster
  20. position_controllers
  21. range_sensor_broadcaster
  22. steering_controllers_library
  23. tricycle_controller
  24. tricycle_steering_controller
  25. velocity_controllers

This is an automatic backport of pull request #1973 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Dec 10, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Dec 10, 2025

Cherry-pick of fcf89fc has failed:

On branch mergify/bp/jazzy/pr-1973
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit fcf89fc.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   ackermann_steering_controller/test/test_ackermann_steering_controller.hpp
	modified:   admittance_controller/test/test_admittance_controller.hpp
	modified:   bicycle_steering_controller/test/test_bicycle_steering_controller.hpp
	modified:   chained_filter_controller/test/test_chained_filter.cpp
	modified:   chained_filter_controller/test/test_multiple_chained_filter.cpp
	modified:   diff_drive_controller/test/test_diff_drive_controller.cpp
	modified:   force_torque_sensor_broadcaster/test/test_force_torque_sensor_broadcaster.cpp
	modified:   gps_sensor_broadcaster/test/test_gps_sensor_broadcaster.cpp
	modified:   joint_state_broadcaster/test/test_joint_state_broadcaster.cpp
	modified:   joint_trajectory_controller/test/test_trajectory_controller_utils.hpp
	modified:   mecanum_drive_controller/test/test_mecanum_drive_controller.hpp
	modified:   omni_wheel_drive_controller/test/test_omni_wheel_drive_controller.cpp
	modified:   omni_wheel_drive_controller/test/test_omni_wheel_drive_controller.hpp
	modified:   parallel_gripper_controller/test/test_parallel_gripper_controller.cpp
	modified:   pid_controller/test/test_pid_controller.hpp
	modified:   pose_broadcaster/test/test_pose_broadcaster.cpp
	modified:   range_sensor_broadcaster/test/test_range_sensor_broadcaster.cpp
	modified:   steering_controllers_library/test/test_steering_controllers_library.hpp
	modified:   tricycle_controller/test/test_tricycle_controller.cpp
	modified:   tricycle_steering_controller/test/test_tricycle_steering_controller.hpp

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   effort_controllers/test/test_joint_group_effort_controller.cpp
	both modified:   forward_command_controller/test/test_forward_command_controller.cpp
	both modified:   forward_command_controller/test/test_multi_interface_forward_command_controller.cpp
	both modified:   gpio_controllers/test/test_gpio_command_controller.cpp
	both modified:   imu_sensor_broadcaster/test/test_imu_sensor_broadcaster.cpp
	deleted by us:   motion_primitives_controllers/test/test_motion_primitives_forward_controller.hpp
	both modified:   position_controllers/test/test_joint_group_position_controller.cpp
	both modified:   velocity_controllers/test/test_joint_group_velocity_controller.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.77%. Comparing base (4a18571) to head (a7ef282).
⚠️ Report is 1 commits behind head on jazzy.

Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #2068      +/-   ##
==========================================
+ Coverage   84.58%   84.77%   +0.18%     
==========================================
  Files         143      143              
  Lines       13867    14034     +167     
  Branches     1229     1229              
==========================================
+ Hits        11730    11897     +167     
  Misses       1703     1703              
  Partials      434      434              
Flag Coverage Δ
unittests 84.77% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...roller/test/test_ackermann_steering_controller.hpp 88.28% <100.00%> (+0.66%) ⬆️
...nce_controller/test/test_admittance_controller.hpp 95.05% <100.00%> (+0.16%) ⬆️
...ntroller/test/test_bicycle_steering_controller.hpp 85.71% <100.00%> (+1.00%) ⬆️
...ned_filter_controller/test/test_chained_filter.cpp 100.00% <100.00%> (ø)
...r_controller/test/test_multiple_chained_filter.cpp 100.00% <100.00%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 94.18% <100.00%> (+0.21%) ⬆️
...ollers/test/test_joint_group_effort_controller.cpp 98.55% <100.00%> (+0.11%) ⬆️
...ster/test/test_force_torque_sensor_broadcaster.cpp 98.50% <100.00%> (+0.04%) ⬆️
...ontroller/test/test_forward_command_controller.cpp 98.70% <100.00%> (+0.04%) ⬆️
...est_multi_interface_forward_command_controller.cpp 99.16% <100.00%> (+0.03%) ⬆️
... and 17 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit a9e36ac into jazzy Dec 10, 2025
10 of 13 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/jazzy/pr-1973 branch December 10, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants