[gpio_controllers] Fix crash on NaN state values and sanitize inputs #2103
+95
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #1970 ("Boolean data type signals are not supported by GPIO Controller"). Users were encountering crashes and exceptions when reading states, likely due to uninitialized values or type mismatches.
I have introduced a
sanitize_doublehelper function to handle state readings.Approach & Reasoning:
Instead of a hard cast to bool, this function detects
NaN(uninitialized memory) or invalid values and defaults them safely to0.0. This stops the crashes while preserving the originaldoublevalue if valid.This supports both use cases:
I have also updated the
ReproduceBadCastCrashtest case toEXPECT_NO_THROWto verify that these edge cases are now handled gracefully.Resolves #1970