broadcaster for magnetic field values from a magnetometer#2214
broadcaster for magnetic field values from a magnetometer#2214christianrauch wants to merge 2 commits intoros-controls:masterfrom
Conversation
|
Hey @christianrauch, I see its some usage. Let's see what maintainers have to say. And another thing, why is the class declaration is in implementation file (everything is in .cpp file). It'll be really better if declaration was in .hpp and implementation was in .cpp |
9d9b9fc to
22c1d40
Compare
There was a problem hiding this comment.
The hpp/cpp comment is a good catch indeed but since this is delivered as a plugin I'm not too concerned about it. Thanks for pointing it out @thedevmystic
22c1d40 to
cddcb89
Compare
|
I addressed the one comment about the maintainers and fixed one CI issue from my side. The CI shows a couple of other issues, such as missing dependencies on |
cddcb89 to
45bea18
Compare
This PR adds a broadcaster for magnetometers via the
semantic_components::MagneticFieldSensor, similar to how this is done for other semantic components (semantic_components::IMUSensor,semantic_components::ForceTorqueSensor).colcon testandpre-commit run(requires you to install pre-commit bypip3 install pre-commit)