Skip to content

[JSB] Fix joint_state message corruption issue#2217

Merged
christophfroehlich merged 3 commits intoros-controls:masterfrom
pal-robotics-forks:fix/jsb/corruption
Mar 17, 2026
Merged

[JSB] Fix joint_state message corruption issue#2217
christophfroehlich merged 3 commits intoros-controls:masterfrom
pal-robotics-forks:fix/jsb/corruption

Conversation

@saikishor
Copy link
Copy Markdown
Member

This fixes the issue reported by @christophfroehlich that sometimes the joint state message is corrupted with incorrect data.

image image

@saikishor saikishor added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Mar 17, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.64%. Comparing base (88138fb) to head (38d0e25).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2217      +/-   ##
==========================================
+ Coverage   84.60%   84.64%   +0.03%     
==========================================
  Files         153      153              
  Lines       14958    14987      +29     
  Branches     1297     1299       +2     
==========================================
+ Hits        12655    12685      +30     
  Misses       1828     1828              
+ Partials      475      474       -1     
Flag Coverage Δ
unittests 84.64% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._state_broadcaster/src/joint_state_broadcaster.cpp 69.68% <100.00%> (+0.69%) ⬆️
..._broadcaster/test/test_joint_state_broadcaster.cpp 97.91% <100.00%> (+0.16%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are the best, thanks for this immediate fix <3

tested in my stack, and the problem is gone.

@christophfroehlich christophfroehlich merged commit 2942d73 into ros-controls:master Mar 17, 2026
16 of 17 checks passed
@christophfroehlich christophfroehlich deleted the fix/jsb/corruption branch March 17, 2026 18:56
mergify bot pushed a commit that referenced this pull request Mar 17, 2026
mergify bot pushed a commit that referenced this pull request Mar 17, 2026
(cherry picked from commit 2942d73)

# Conflicts:
#	joint_state_broadcaster/src/joint_state_broadcaster.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants