[Draft] Remove deprecated publish_rate from diff_drive_controller#2259
Draft
Bhavin-umatiya wants to merge 1 commit intoros-controls:masterfrom
Draft
[Draft] Remove deprecated publish_rate from diff_drive_controller#2259Bhavin-umatiya wants to merge 1 commit intoros-controls:masterfrom
Bhavin-umatiya wants to merge 1 commit intoros-controls:masterfrom
Conversation
Contributor
|
This pull request is in conflict. Could you fix it @Bhavin-umatiya? |
christophfroehlich
requested changes
Mar 29, 2026
Member
christophfroehlich
left a comment
There was a problem hiding this comment.
Thank you. Please rebase this on top of master as the deprecation PR got merged now.
9fe719a to
1bbdc98
Compare
Contributor
Author
|
Thank you, @christophfroehlich. I have rebased the branch on the latest master and resolved the merge conflicts. The PR is now up to date with the merged deprecation code. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2259 +/- ##
==========================================
+ Coverage 84.68% 84.69% +0.01%
==========================================
Files 153 153
Lines 15319 15307 -12
Branches 1332 1329 -3
==========================================
- Hits 12973 12965 -8
+ Misses 1858 1856 -2
+ Partials 488 486 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following the deprecation in PR #2245, this follow-up PR removes the deprecated
publish_rateparameter and its associated logic fromdiff_drive_controller.This includes:
publish_ratefromdiff_drive_controller_parameter.yaml.publish_rate_,publish_period_, andprevious_publish_timestamp_from the controller header.This PR is set as a Draft as requested by @christophfroehlich, to be merged after the next project sync.