Remove unnecessary publish_limited_velocity_ member variable#2265
Closed
greencookie-afk wants to merge 1 commit intoros-controls:masterfrom
Closed
Conversation
Use params_.publish_limited_velocity directly instead of maintaining a separate member variable that mirrors the parameter value.
github-actions
bot
requested review from
Juliaj,
bijoua29,
christophfroehlich,
destogl and
erickisos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish_limited_velocity_member variable fromDiffDriveControllerparams_.publish_limited_velocitydirectly instead of maintaining a separate copyMotivation
As noted in issue #2246,
publish_limited_velocity_is just a copy ofparams_.publish_limited_velocity. Sinceparams_is already a class member, there's no need to maintain this redundant state.Changes
bool publish_limited_velocity_ = false;from the header filepublish_limited_velocity_withparams_.publish_limited_velocityin the implementationFixes #2246