Remove unnecessary publish_limited_velocity_ member#2266
Merged
christophfroehlich merged 1 commit intoros-controls:masterfrom Mar 31, 2026
Merged
Conversation
thedevmystic
approved these changes
Mar 31, 2026
Contributor
There was a problem hiding this comment.
Hi, @ZacharyLain! Thank you for your interest in the project!
The PR looks great!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2266 +/- ##
==========================================
- Coverage 84.68% 84.68% -0.01%
==========================================
Files 153 153
Lines 15319 15318 -1
Branches 1332 1332
==========================================
- Hits 12973 12972 -1
Misses 1858 1858
Partials 488 488
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
2bf3093
into
ros-controls:master
18 of 19 checks passed
mergify bot
pushed a commit
that referenced
this pull request
Mar 31, 2026
(cherry picked from commit 2bf3093)
mergify bot
pushed a commit
that referenced
this pull request
Mar 31, 2026
(cherry picked from commit 2bf3093)
christophfroehlich
pushed a commit
that referenced
this pull request
Apr 2, 2026
christophfroehlich
pushed a commit
that referenced
this pull request
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish_limited_velocity_member from theDiffDriveController.Changes
publish_limited_velocity_from the header file.publish_limited_velocity_withparams_.publish_limited_velocityin the implementation.Closes #2246