Skip to content

Remove unnecessary publish_limited_velocity_ member#2266

Merged
christophfroehlich merged 1 commit intoros-controls:masterfrom
ZacharyLain:diffdrive-remove-unused-member
Mar 31, 2026
Merged

Remove unnecessary publish_limited_velocity_ member#2266
christophfroehlich merged 1 commit intoros-controls:masterfrom
ZacharyLain:diffdrive-remove-unused-member

Conversation

@ZacharyLain
Copy link
Copy Markdown
Contributor

Summary

  • Removed the redundant publish_limited_velocity_ member from the DiffDriveController.

Changes

  • Removed publish_limited_velocity_ from the header file.
  • Replaced uses of publish_limited_velocity_ with params_.publish_limited_velocity in the implementation.

Closes #2246

Copy link
Copy Markdown
Contributor

@thedevmystic thedevmystic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @ZacharyLain! Thank you for your interest in the project!

The PR looks great!

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.68%. Comparing base (fc570f8) to head (8f0ebdb).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...iff_drive_controller/src/diff_drive_controller.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2266      +/-   ##
==========================================
- Coverage   84.68%   84.68%   -0.01%     
==========================================
  Files         153      153              
  Lines       15319    15318       -1     
  Branches     1332     1332              
==========================================
- Hits        12973    12972       -1     
  Misses       1858     1858              
  Partials      488      488              
Flag Coverage Δ
unittests 84.68% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...iff_drive_controller/src/diff_drive_controller.cpp 80.36% <0.00%> (-0.06%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Mar 31, 2026
Copy link
Copy Markdown
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@christophfroehlich christophfroehlich merged commit 2bf3093 into ros-controls:master Mar 31, 2026
18 of 19 checks passed
mergify bot pushed a commit that referenced this pull request Mar 31, 2026
mergify bot pushed a commit that referenced this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DiffDrive: Remove unnecessary member variable

3 participants