Skip to content

Remove ament linters 2263#2267

Merged
christophfroehlich merged 2 commits intoros-controls:masterfrom
rainingmp3:remove-ament-linters-2263
Mar 31, 2026
Merged

Remove ament linters 2263#2267
christophfroehlich merged 2 commits intoros-controls:masterfrom
rainingmp3:remove-ament-linters-2263

Conversation

@rainingmp3
Copy link
Copy Markdown
Contributor

Description

  • Removed all mentions of ament_lint_auto and ament_lint_common in dependency and CMakeLists.txt files.

Related Issue

Closes #2263

Copy link
Copy Markdown
Contributor

@thedevmystic thedevmystic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @rainingmp3! Thank you for your interest in the project!

PR looks good to me! Keep it up!

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.68%. Comparing base (fc570f8) to head (f7d57a1).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2267   +/-   ##
=======================================
  Coverage   84.68%   84.68%           
=======================================
  Files         153      153           
  Lines       15319    15319           
  Branches     1332     1332           
=======================================
  Hits        12973    12973           
  Misses       1858     1858           
  Partials      488      488           
Flag Coverage Δ
unittests 84.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rainingmp3
Copy link
Copy Markdown
Contributor Author

@thedevmystic Thank you!) I am looking forward to contribute more!

Copy link
Copy Markdown
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@christophfroehlich christophfroehlich added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Mar 31, 2026
@christophfroehlich christophfroehlich merged commit 7d3babc into ros-controls:master Mar 31, 2026
19 checks passed
mergify bot pushed a commit that referenced this pull request Mar 31, 2026
(cherry picked from commit 7d3babc)
mergify bot pushed a commit that referenced this pull request Mar 31, 2026
(cherry picked from commit 7d3babc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove ament linters

3 participants