Implement repository filters#764
Conversation
mathias-luedtke
force-pushed
the
feature/repository-filter
branch
from
8e94506 to
e33ddb5
Compare
rhaschke
left a comment
rhaschke
left a comment
There was a problem hiding this comment.
Looks good. Thanks for your effort!
You should also consider augmenting the docs.
I noticed a minor issue when testing:
-folder1,folder2 doesn't keep folder2 only as expected (but this usage is not meaningful)
| ici_import_repository "$sourcespace" "$source" "$filter" | ||
| ;; | ||
| http://* | https://*) # When UPSTREAM_WORKSPACE is an http url, use it directly | ||
| ici_import_url "$sourcespace" "$source" |
There was a problem hiding this comment.
Did you skip the filter for ici_import_url intentionally?
There was a problem hiding this comment.
Yes. There is no specific folder that can be filtered in this case.
| ici_log "Copying '$basepath'" | ||
| ici_import_directory "$sourcespace" "$basepath" | ||
| ;; | ||
| /*) |
There was a problem hiding this comment.
The code here for /*) and below for *) is rather similar. Do you want to factor that out into a separate function?
There was a problem hiding this comment.
Good point! I will make it a fall-through
The order is important.. If the list starts with "-", the complete repo will be used (otherwise there is nothing to delete from..). |
mathias-luedtke
force-pushed
the
feature/repository-filter
branch
from
13aa5ed to
979a02a
Compare
mathias-luedtke
force-pushed
the
feature/repository-filter
branch
from
979a02a to
fd671d9
Compare
2 participants
Alternative to #763
New syntax:
UPSTREAM_WORKSPACE='github:ros-controls/ros_control#melodic-devel,-rqt_controller_manager'UPSTREAM_WORKSPACE='github:ros-controls/ros_control#melodic-devel,rqt_controller_manager,-rqt_controller_manager/CHANGELOG.rstUPSTREAM_WORKSPACE='local_folder,-sub_folder(untested)@rhaschke: Please have a look
Instead of "+" I used the already existing syntax for copying sub-folders.
If filter starts with "-", the filter operates on the cloned repository directly.