Run clang_format_check in deterministic location#768
Open
wxmerkt wants to merge 2 commits into
Open
Conversation
wxmerkt
force-pushed
the
topic/clang-format-check-in-deterministic-location
branch
from
7f7c70b to
0acf08f
Compare
mathias-luedtke
requested changes
Jan 8, 2022
mathias-luedtke
left a comment
mathias-luedtke
left a comment
Member
There was a problem hiding this comment.
This is not working at all. That's why the tests fail.
| local err=0 | ||
| local path | ||
| ici_make_temp_dir path | ||
| function install_clang_format_check() { |
Member
There was a problem hiding this comment.
This function never gets called..
Contributor
Author
There was a problem hiding this comment.
Indeed, thanks for pointing this out - I made a wrong assumption about the calling order. I've now simplified it. It works by e.g. setting BEFORE_RUN_CLANG_FORMAT_CHECK="wget [my config] -O /tmp/clang_format_check/[project]/.clang-format" along with ADDITIONAL_DEBS=wget in this case.
To download a custom config file, use BEFORE_RUN_CLANG_FORMAT_CHECK="wget [my_config] -O /tmp/clang_format_check/[project-name]/.clang-format". You also need to set ADDITIONAL_DEBS=wget
Contributor
Author
|
Friendly ping - any thoughts on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal to implement #767. It enables to use the
AFTER_INSTALL_CLANG_FORMAT_CHECKhook to download a clang-format file into/tmp/clang_format_check/$PROJECT_NAME