Use shallow import with VCS#842
Open
marip8 wants to merge 1 commit into
Open
Conversation
Member
Author
|
Any ideas why the ABI check test fails on |
Member
That test checks the ABI against a previous commit and it does not exist in a shallow clone.. |
mathias-luedtke
requested changes
Nov 20, 2023
mathias-luedtke
left a comment
mathias-luedtke
left a comment
Member
There was a problem hiding this comment.
This might break existing setups (just as it breaks the ABI test).
Not sure, if we should make it an opt-in or opt-out behavior..
VCS_IMPORT_SHALLOW?
It must get set to false, if ABICHECK_MERGE=true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes per commit message to reduce overall setup time (and resultant docker image size) when working with large projects.