Add documentation for github private repos#900
Conversation
|
Pinging for review. I think this is a small, straight forward change that will save people hours of research. |
130s
left a comment
There was a problem hiding this comment.
I'm a weak user of Github Action and reviewed from that perspective, can't verify the legitimacy.
130s
left a comment
There was a problem hiding this comment.
Thanks for iterating @AndyZe.
@mathias-luedtke Care to review?
|
Ping |
mathias-luedtke
left a comment
There was a problem hiding this comment.
This does not enable access to private repositories (like the Gitlab version), but clones selected repositories into the current repositories (which might lead to nested packages).
These shortcomings must be stated with a warning!
Or (preferred) we implement support for SSH secrets, like we do for Gitlab.
|
@AndyZe: #902 has feature parity with the gitlab implemantation. For multiple deploy keys, |
|
Alright, I'll take the time to test #902. Thanks |
I took care of the "nested packages" issue by adding a unique path for each repository. |
I got the idea from here: https://stackoverflow.com/a/72883304/3499467