Use fixed period for update call of controller manager#132
Open
hartmanndennis wants to merge 4 commits into
Open
Use fixed period for update call of controller manager#132hartmanndennis wants to merge 4 commits into
hartmanndennis wants to merge 4 commits into
Conversation
Contributor
Author
|
The workaround works for me with RSI 2.3. |
Member
|
We're having some problems with our KR210 here, so I can't really test this. If someone else from the regulars here would care to test this PR, that would be greatly appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for my suggestion in #126
Tested on KR5 with KRC4 and RSI 3.3 and it works very well both with IPO and IPO_FAST.
There is a problem with RSI 2.3 on KRC2 though. Here, IPOC gets increased by 1 instead of the cycletime of 12ms. Maybe I could use the check in
kuka_hardware_interface.cppto check for KRC2 and multiply the duration by 12 in this case?