WIP: PR #358 rebased for melodic devel staging #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavanderhoorn
requested changes
Sep 29, 2021
Member
gavanderhoorn
left a comment
gavanderhoorn
left a comment
There was a problem hiding this comment.
I believe this PR should really only touch ur_kinematics. All changes to other packages should be removed / avoided.
Also: changes to CHANGELOGs (and similar files) should also not be included.
I realise this may not be trivial (due to this being a rebase).
Member
|
@dhled: would you see an opportunity to fix the PR? |
Author
|
Yes, I will try to do that this week. |
…nd added an appropriate helper function.
…ven kinematic configuration.
…full range of joint limits. Rotates joint by +-360° if it is possible and gets the solution closer to the seed.
Co-authored-by: Simon Schmeisser <[email protected]>
Co-authored-by: Simon Schmeisser <[email protected]>
dhled
force-pushed
the
358_Melodic_devel_staging
branch
from
0e606f4 to
6ad0898
Compare
Author
|
I still need to test on UR and UR-E, I will try to that later today / tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #358 to target to melodic-devel-staging
Not tested yet.