-
Notifications
You must be signed in to change notification settings - Fork 3
Feat (VDA5050 master) : Initial commit of VDA5050 Master Codebase #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tanjpg
wants to merge
32
commits into
ros-industrial:develop
Choose a base branch
from
tanjpg:ci-ready/vda-master
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructs and handler structs. Parsing to be handled by external function handles
…icies Signed-off-by: Tan Jing Peng Glenn <[email protected]>
Signed-off-by: Tan Jing Peng Glenn <[email protected]>
Signed-off-by: Tan Jing Peng Glenn <[email protected]>
Signed-off-by: Tan Jing Peng Glenn <[email protected]>
Signed-off-by: Tan Jing Peng Glenn <[email protected]>
Signed-off-by: Tan Jing Peng Glenn <[email protected]>
Signed-off-by: Tan Jing Peng Glenn <[email protected]>
…tes and AGV Connection as enums, added State and Connection Heartbeat into AGV Class Signed-off-by: Tan Jing Peng Glenn <[email protected]>
Signed-off-by: Tan Jing Peng Glenn <[email protected]>
Signed-off-by: Tan Jing Peng Glenn <[email protected]>
…Connection broken only for heartbeat lapses or explicit mention of connectionbroken. Signed-off-by: Tan Jing Peng Glenn <[email protected]>
Signed-off-by: Tan Jing Peng Glenn <[email protected]>
…externally is not available Signed-off-by: Tan Jing Peng Glenn <[email protected]>
…he AGV state if disconnected or connection lost. Minor sleep to allow paho to cleanup as well. Signed-off-by: Tan Jing Peng Glenn <[email protected]>
Signed-off-by: Tan Jing Peng Glenn <[email protected]>
Signed-off-by: Tan Jing Peng Glenn <[email protected]>
Signed-off-by: Tan Jing Peng Glenn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the commits for the current initial status of the VDA5050 master prototype package. Future PRs to this package will be incremental.
Features
1. Abstracted communication layer
The ICommunicationStrategy class contains a generic class for communication from the VDA5050 Master to the VDA5050 AGV.
We use the generic ConnectionState enum to represent the connection states.
There are currently 2 implementations of this class.
1a. MqttCommunication (Inherits
ICommunicationStrategy)MqttCommunication contains the MQTT Implementation of the
ICommunicationStrategyclass. This uses themqtt_clientimplementation of the mqtt client as the base API layerUnit tests for this class here
1b. Ros2Communication (Inherits
ICommunicationStrategy)Ros2Communication contains standard implementation of ROS2 related pub-sub architecture.
Unit tests for this class here
2. Heartbeat implementation
As per the VDA5050 specifications, the
connectionandstatetopics require a certain minimum frequency of publishing. The HeartbeatListener class is the generic listener that will take callbacks to handle the state transition for the AGV givenconnectionorstatemessage lapses.Unit tests for this class here
3. AGV class implementation
This current design uses the AGV class with its own individual
ICommunicationStrategypubs and subs. these subs will handle two different states. The AGVConnectionState enum handles theconnectionmessage related state transitions, while the AGVState enum handlesstatemessage related state transitions. These topic subs will have separateHeartbeatListenersUnit tests for class here
3a. AGVConnectionState state transition
When AGV is first onboarded, or when disconnected explicitly-
OFFLINEWhen no
connectionmessage received after seconds - 'CONNECTIONBROKEN`When receiving online status -
ONLINEUnit tests for state transitions here
3.b AGVState state transition
When AGV is first onboarded -
STATE_UNKNOWNWhen
statemessage comes in -AVAILABLEWhen
statemessage does not come in and heartbeat fails -STATE_UNKNOWNIf ever
AGVConnectionStatetransitions toOFFLINEorCONNECTIONBROKEN-UNAVAILABLEAny errors reported in
statemessage -ERRORUnit tests for this state transition here
4. VDA5050 Master
An initial skeleton of how (1) to (3) ties in together is shown in the VDA5050Master class. The main thing added here is the onboarding and offboarding methods (
register_agvandunregister_agv). Simple functions for publishing toorderandinstant actionsare also added.Unit tests for this class is also in the same file as the one for
AGVhere Since the main functions to test are mainlyregisteringandunregisteringAGVsIn future, the main VDA5050 workflow logic will be added to this class.