enable parallel builds for debian

[christianrauch]

By default, depending on the CMake generator, build jobs do not run in parallel. Fix this by passing the --parallel flag which then allows to run parallel jobs by passing options to DEB_BUILD_OPTIONS, e.g. DEB_BUILD_OPTIONS="parallel=8" fakeroot debian/rules binary.

[cottsay]

The Debian and RPM jobs run on buildfarm workers with a per-package approach to parallelism, wherein each package is allocated a single core.

That said, this is a buildfarm implementation detail and it would be nice if it didn't "leak" into Bloom like this. The RPM builds are parallel by default and a buildfarm flag limits them to a single core.

If there is a similar approach for the Debian builds so that we can maintain the desired behavior on the buildfarm, we can consider this change.

[jspricke]

The better way here would be to bump the compat version (Debian is at 13 nowadays), as proposed in #643.

If there is a similar approach for the Debian builds so that we can maintain the desired behavior on the buildfarm, we can consider this change.

By exporting DEB_BUILD_OPTIONS ;).

[russkel]

By exporting DEB_BUILD_OPTIONS ;).

Elegance defined.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@09e4cee). Learn more about missing BASE report.

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #715   +/-   ##
=========================================
  Coverage          ?   54.58%           
=========================================
  Files             ?       52           
  Lines             ?     6363           
  Branches          ?     1128           
=========================================
  Hits              ?     3473           
  Misses            ?     2551           
  Partials          ?      339           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[russkel]

This didn't actually work for me. I still had to specify DEB_BUILD_OPTIONS=parallel=8 for it to work. Otherwise it would always call make with -j1. I could never get it to specify unlimited jobs either -j. This is with deb compat set to 13.

[jspricke]

@russkel can you share a log? Preferably with all package version like sbuild will get it. The feature is used in all over Debian so it would be surprising if it fails for you.

[russkel]

I worry that our stuff has deviated from the upstream bloom repo and may have caused it (https://github.com/Greenroom-Robotics/bloom)

@russkel can you share a log? Preferably with all package version like sbuild will get it. The feature is used in all over Debian so it would be surprising if it fails for you.

The package versions should be the latest or quite modern on both our noble and jammy images. A log is not so easy to get at this second.

[christianrauch]

@cottsay Given that #643, the preferred way to enable parallel builds amongst others, stalled, could you at least consider this PR to enable parallel builds without increasing the compat version? If you are worried by the parallel processes, you can set DEB_BUILD_OPTIONS on the build farm.