-
Notifications
You must be signed in to change notification settings - Fork 99
Default the homepage in the packaging metadata if not otherwise declared by the package #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…red by the package.
|
This pull request has been mentioned on Open Robotics Discourse. There might be relevant details there: https://discourse.openrobotics.org/t/how-do-you-access-changelogs-for-ros-2-releases/50530/2 |
| data['Version'] = package.version | ||
| data['Description'] = format_description(package.description) | ||
| # Websites | ||
| websites = [str(url) for url in package.urls if url.type == 'website'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would rather visit any other websites in the package.xml than the distro index.
I personally would go for:
- website
- source
- doc
- fallback to index
The source or the docs gives me more insight in the package than the index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not the index? It contains all the other links you're mentioning (or it should).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the index contains all urls from the package.xml that could work as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As well as the link to the source in the Repository summary, the Doc in the API Docs right side menu. As well as Browse Source with the package specific path into the repository.
It lists any provided urls in the "Additional Links" section
ex: https://index.ros.org/p/depthai/#kilted

The goal is to have one central clearing hub with all the info.
Co-authored-by: Martin Pecka <[email protected]>
An alternative or complement to ros-infrastructure/reprepro-updater#240